Changeset 891636a

Timestamp:

Apr 18, 2013 7:56:14 AM (5 weeks ago)

Author:

Ken Moore <ken@…>

Branches:

master, 9.1-release

Children:

aa082fc

Parents:

92b4ba0

Message:

Get the mountTray saving/loading it's settings properly, and integrate those settings with the new Settings dlialog. You can now turn the disk space watcher off/on and set the refresh times/flags within the settings dialog.

Location:

src-qt4/pc-mounttray

Files:

• fsDialog.cpp (modified) (1 diff)
• fsDialog.h (modified) (1 diff)
• fsWatcher.cpp (modified) (4 diffs)
• fsWatcher.h (modified) (2 diffs)
• mountTray.cpp (modified) (8 diffs)
• mountTray.h (modified) (4 diffs)
• pc-mounttray.pro (modified) (2 diffs)
• pc-mounttray.qrc (modified) (1 diff)
• settingsDialog.cpp (modified) (1 diff)
• settingsDialog.h (modified) (1 diff)

src-qt4/pc-mounttray/fsDialog.cpp

@@ -61 +61 @@
   QHBoxLayout *hb = new QHBoxLayout();
   hb->addStretch();
-  QPushButton *closeButton = new QPushButton("Close");
+  QPushButton *closeButton = new QPushButton(QIcon(":icons/application-exit.png"),tr("Close"));
   hb->addWidget(closeButton);
   hb->addStretch();

src-qt4/pc-mounttray/fsDialog.h

@@ -12 +12 @@
 #include <QBrush>
 #include <QColor>
+#include <QIcon>
 
 #include "fsWatcher.h"

src-qt4/pc-mounttray/fsWatcher.cpp

@@ -4 +4 @@
   //setup the timer
   timer = new QTimer();
+  timer->setSingleShot(TRUE);
   QObject::connect(timer, SIGNAL(timeout()), this, SLOT(checkFS()));
 }
@@ -11 +12 @@
 
 void FSWatcher::start(int ms){ 
-    timer->start(ms); 
+    timer->stop();
+    timer->setInterval(ms); //max time between system checks
+    timer->start(); 
     QTimer::singleShot(2000,this,SLOT(checkFS()) ); //make sure to perform a check when it starts up
 }
@@ -100 +103 @@
 }
 
-//====== Private Slot =======
+//====== Public Slot =======
 void FSWatcher::checkFS(){
   QStringList devList = getFSmountpoints();
@@ -117 +120 @@
     emit FSWarning(title,message);
   }
+  timer->start(); //reset the timer again
 }
 
+//===== Calculate Percentages =====
 int FSWatcher::calculatePercentage(int used, int total){
   double U = used;

src-qt4/pc-mounttray/fsWatcher.h

@@ -10 +10 @@
 #include <QCoreApplication>
 #include <QDebug>
+
 
 class FSWatcher : public QObject
@@ -31 +32 @@
   static int calculatePercentage(int,int);
   
-private slots:
+public slots:
   void checkFS(); //function in a timer loop
 

src-qt4/pc-mounttray/mountTray.cpp

@@ -21 +21 @@
   getInitialUsername(); //try to detect the non-root user who is running the program with root permissions
   getDefaultFileManager(); //try to detect the default file-manager for opening the mount directory
+  loadSavedSettings();
   
   trayIcon = new QSystemTrayIcon(this);
@@ -33 +34 @@
     //Add the setting dialog option seperately
     sysMenu->addSeparator();
-    sysMenu->addAction( QIcon(":icons/config.png"), tr("Settings"), this, SLOT(slotOpenSettings()) );
+    sysMenu->addAction( QIcon(":icons/config.png"), tr("Change Settings"), this, SLOT(slotOpenSettings()) );
     //Add the Close button seperately
     sysMenu->addSeparator();
@@ -57 +58 @@
   
   //Start up the filesystem watcher
-  qDebug() << "-Starting up the disk space alert system";
   diskWatcher = new FSWatcher();
   connect(diskWatcher,SIGNAL(FSWarning(QString,QString)),this,SLOT(slotDisplayWarning(QString,QString)));
-  diskWatcher->start(3600000); // check every 1 hour in milliseconds
+  if(useDiskWatcher){ 
+    qDebug() << "-Starting up the disk space alert system";
+    diskWatcher->start(diskTimerMaxMS); 
+  }
   
   //Update the tray menu and icons
@@ -173 +176 @@
 
 void MountTray::newDevdMessage(){       
-  devdTimer->start(1000); //wait 1.5 seconds before checking for device changes
+  devdTimer->start(1500); //wait 1.5 seconds before checking for device changes
   return;
 }
@@ -251 +254 @@
     }
   } //end loop over cd/dvd devices
+  
+  //Run the disk space check if appropriate
+  if(useDiskWatcher && useDiskTimerDevd && showPopup){ diskWatcher->checkFS(); }
 }
 
@@ -340 +346 @@
     deviceList[i]->updateItem();
   }
+  //Run the disk check if appropriate
+  if(useDiskWatcher){ diskWatcher->checkFS(); }
 }
 
@@ -349 +357 @@
 
 void MountTray::slotOpenSettings(){
+  //Stop the refresh timer on the watcher
+  diskWatcher->stop();
   //Open up the settings window and apply changes as necessary
-  qDebug() << "Settings window not implemented yet";
+  SettingsDialog *sdlg = new SettingsDialog();
+  sdlg->useDiskWatcher = useDiskWatcher;
+  sdlg->useDiskAutoTimer = useDiskTimerDevd;
+  sdlg->diskRefreshMS = diskTimerMaxMS;
+  sdlg->showDialog();
+  //Now parse the output and save if necessary
+  if(sdlg->SettingsChanged){
+    useDiskWatcher = sdlg->useDiskWatcher;
+    useDiskTimerDevd = sdlg->useDiskAutoTimer;
+    diskTimerMaxMS = sdlg->diskRefreshMS;
+    qDebug() << "INFO: Saving updated settings to file";
+    saveCurrentSettings(); //update the saved settings
+  }
+  //Now restart the disk watcher if enabled
+  if(useDiskWatcher){ diskWatcher->start(diskTimerMaxMS); }
 }
 
@@ -373 +397 @@
   trayIcon->showMessage(title, msg , QSystemTrayIcon::Warning,5000 );
 }
+
+void MountTray::loadSavedSettings(){
+  //The saved settings file
+  QString filename = QDir::homePath()+"/.mounttray.settings";
+  //Set the defaults
+  useDiskWatcher=TRUE; useDiskTimerDevd=TRUE;
+  diskTimerMaxMS=3600000; //1 hour refresh timer
+  //Now load the file
+  QFile file(filename);
+  if(file.exists()){
+    if(!file.open(QIODevice::ReadOnly | QIODevice::Text)){ 
+      qDebug() << "-Could not open settings file: using defaults";
+      return; 
+    }
+    QTextStream in(&file);
+    while(!in.atEnd()){
+      QString line = in.readLine();
+      if(!line.startsWith("#")){ //skip comment lines
+        QString var = line.section(")",0,0,QString::SectionSkipEmpty).simplified();
+        QString val = line.section(")",1,30,QString::SectionSkipEmpty).simplified();
+        if(var=="UseDiskSpaceMonitoring"){ 
+          if(val.toLower() == "true"){ useDiskWatcher = TRUE;}
+          else{ useDiskWatcher = FALSE; }
+        }else if(var=="UseDiskSpaceDevdTiming"){
+          if(val.toLower() == "true"){ useDiskTimerDevd = TRUE;}
+          else{ useDiskTimerDevd = FALSE; }     
+        }else if(var=="DiskSpaceTimingMaxMilliseconds"){
+          diskTimerMaxMS = val.toInt(); 
+        }
+      }
+    }
+    file.close();
+  }else{
+    qDebug() << "-Creating new settings file with defaults";
+    saveCurrentSettings();
+  }
+}
+
+void MountTray::saveCurrentSettings(){
+  //The saved settings file
+  QString filename = QDir::homePath()+"/.mounttray.settings";
+  //Now write the current values to the file
+  QFile file(filename);
+  if(!file.open(QIODevice::WriteOnly | QIODevice::Text)){
+    qDebug() << "ERROR: Could not open file to save settings:"<<filename;
+    return;
+  }
+  QTextStream out(&file);
+  out << "#pc-mounttray saved settings file\n";
+  out << "# DO NOT EDIT: Use the settings dialog in the application instead!!\n";
+  //Save the settings
+  out << "UseDiskSpaceMonitoring)";
+  if(useDiskWatcher){ out << "true\n";}
+  else{ out << "false\n"; }
+  out << "UseDiskSpaceDevdTiming)";
+  if(useDiskTimerDevd){ out << "true\n";}
+  else{ out << "false\n"; }
+  out << "DiskSpaceTimingMaxMilliseconds)"+QString::number(diskTimerMaxMS)+"\n";
+  //Now close the file
+  file.close();
+}

src-qt4/pc-mounttray/mountTray.h

@@ -11 +11 @@
 #include <QList>
 #include <QTimer>
+#include <QDir>
+#include <QFile>
+#include <QTextStream>
 
 #include "menuItem.h"
@@ -16 +19 @@
 #include "fsWatcher.h"
 #include "fsDialog.h"
+#include "settingsDialog.h"
 
 extern bool DEBUG_MODE;
@@ -62 +66 @@
   FSWatcher *diskWatcher;
   FSDialog *diskDisplay;
+  //Saved Settings
+  bool useDiskWatcher, useDiskTimerDevd;
+  int diskTimerMaxMS; //milliseconds
 
 
@@ -71 +78 @@
   void getInitialUsername();
   void getDefaultFileManager();
+  void loadSavedSettings();
+  void saveCurrentSettings();
   
 };

src-qt4/pc-mounttray/pc-mounttray.pro

@@ -11 +11 @@
         devCheck.h \
         fsWatcher.h \
-        fsDialog.h
+        fsDialog.h \
+        settingsDialog.h
 
 SOURCES += main.cpp \
@@ -18 +19 @@
         devCheck.cpp \
         fsWatcher.cpp \
-        fsDialog.cpp
+        fsDialog.cpp \
+        settingsDialog.cpp
 
 RESOURCES += pc-mounttray.qrc

src-qt4/pc-mounttray/pc-mounttray.qrc

@@ -14 +14 @@
     <file>icons/refresh.png</file>
     <file>icons/config.png</file>
+    <file>icons/checkmark.png</file>
   </qresource>
 </RCC>

src-qt4/pc-mounttray/settingsDialog.cpp

@@ -45 +45 @@
   groupDiskWatch->setChecked(useDiskWatcher);
   checkDiskAutoTimer->setChecked(useDiskAutoTimer);
-  spinDiskRefreshMin->setValue(diskRefreshMS/60000);
+  int minutes = diskRefreshMS/60000;
+  //qDebug() << "Refresh Time:"<< QString::number(diskRefreshMS)+" ms, "+QString::number(minutes)+" min";
+  spinDiskRefreshMin->setValue(minutes);
     //Apply signals/slots AFTER setting the values
     connect(groupDiskWatch, SIGNAL(clicked(bool)),this,SLOT(slotUpdateUI(bool)) );

src-qt4/pc-mounttray/settingsDialog.h

@@ -14 +14 @@
 #include <QLabel>
 #include <QIcon>
+#include <QDebug>
 
 class SettingsDialog : public QDialog{